Skip to content

ggml: Add basic SET_ROWS support in WebGPU - #15137

Merged
reeselevine merged 4 commits into
ggml-org:masterfrom
reeselevine:master
Aug 6, 2025
Merged

ggml: Add basic SET_ROWS support in WebGPU#15137
reeselevine merged 4 commits into
ggml-org:masterfrom
reeselevine:master

Conversation

@reeselevine

@reeselevine reeselevine commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

This allows the CI to run using SET_ROWS instead of CPY.

  • Adds basic SET_ROWS f32-> f16 shader/setup
  • Since WGSL does not support 64-bit values, an error should be reported if a SET_ROWS index is > 2^32.
  • To do this, an error value is set in the shader, and GGML_ABORT is called when a later callback sees that there has been an error.
  • This PR also adds code for setting up a debug buffer, which can be useful for understanding what's going on in shaders while developing.

@github-actions github-actions Bot added devops improvements to build systems and github actions ggml changes relating to the ggml tensor library for machine learning labels Aug 6, 2025
@reeselevine
reeselevine merged commit 5fd160b into ggml-org:master Aug 6, 2025
blime4 referenced this pull request in blime4/llama.cpp Feb 5, 2026
@reeselevine shaobo.xie
ggml: Add basic SET_ROWS support in WebGPU (#15137)
2560e09 
* Begin work on set_rows

* Work on set rows

* Add error buffers for reporting unsupported SET_ROWS indices

* Remove extra comments
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
@reeselevine
ggml: Add basic SET_ROWS support in WebGPU (ggml-org#15137)
abd9c0d 
* Begin work on set_rows

* Work on set rows

* Add error buffers for reporting unsupported SET_ROWS indices

* Remove extra comments
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
@reeselevine
ggml: Add basic SET_ROWS support in WebGPU (ggml-org#15137)
00eb82c 
* Begin work on set_rows

* Work on set rows

* Add error buffers for reporting unsupported SET_ROWS indices

* Remove extra comments
fukuro-kun pushed a commit to fukuro-kun/fukuro-llama-cpp-turboquant that referenced this pull request Jul 5, 2026
@reeselevine
ggml: Add basic SET_ROWS support in WebGPU (ggml-org#15137)
4c8a6ba 
* Begin work on set_rows

* Work on set rows

* Add error buffers for reporting unsupported SET_ROWS indices

* Remove extra comments
MrLordCat referenced this pull request in MrLordCat/llama.cpp-rdna-lab Jul 16, 2026
@reeselevine
ggml: Add basic SET_ROWS support in WebGPU (#15137)
93e6f95 
* Begin work on set_rows

* Work on set rows

* Add error buffers for reporting unsupported SET_ROWS indices

* Remove extra comments
zommiommy pushed a commit to zommiommy/llama.cpp that referenced this pull request Aug 18, 2026
@reeselevine @zommiommy
ggml: Add basic SET_ROWS support in WebGPU (ggml-org#15137)
197649c 
* Begin work on set_rows

* Work on set rows

* Add error buffers for reporting unsupported SET_ROWS indices

* Remove extra comments
frostyautumnleaf pushed a commit to frostyautumnleaf/llama.cpp that referenced this pull request Oct 5, 2026
@reeselevine
ggml: Add basic SET_ROWS support in WebGPU (ggml-org#15137)
d34e8a8 
* Begin work on set_rows

* Work on set rows

* Add error buffers for reporting unsupported SET_ROWS indices

* Remove extra comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CISC CISC CISC approved these changes

Assignees

No one assigned

Labels

devops improvements to build systems and github actions ggml changes relating to the ggml tensor library for machine learning

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reeselevine @CISC