Replies: 1 comment
|
The only chance to do anything about this is to reproduce it, I personally haven't seen any regressions from that PR, otherwise I wouldn't have merged it. What's the hardware and software setup of the runner? |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Hi, I'm from the downstram Lemonade team and we see an re-occuring TTFT Vulkan regression that might be due to a code change. Once we found the reason we might be able to bring the good timings back.
We had this in a discord discussion very briefly before, but I do not think the current data can be dismissed as generic runner noise. We don't know for sure, but I would appreciate looking together into #22930 if it might be a part of the problem.
We did not change our script for validation and only the first real model request after loading. Let's consider that llama.cpp's 1 or 2 token warmup does not cover all prompt shapes, Vulkan pipelines are compiled lazily, and internal buffers may grow during the first request. These costs are included in our measurement:
Here are the Lemonade results on the same runner label over time/commit history:
PR #22930 is the only broad Vulkan change is saw that could have caused this clear regression start. It is affecting internal buffer allocation on all UMA devices, such as the tested Stix halo. The current GGML_VK_DISABLE_HOST_VISIBLE_VIDMEM path cannot test this correctly as it seems.
We also see the situation is changing drastically, so I suspect we have mixed effect.
My propsoal to go after this:
A proper same-session A/B test, compare the historical builds, b9747 with #22930 reverted, and b10229 with the older Vulkan SDK. Each model should receive three identical requests so we can separate cold and warm timings. Additionally record pipeline creation time, selected Vulkan memory types, driver details, prompt length, ubatch, flash attention and graph optimization.
After this test we know, ans don't need to speculate anymore.
On my side I opened a PR lemonade-sdk/lemonade#2915 with the intend to stabilize the runner, review changes are due.
Hope we can tackle this together @0cc4m I also have the hardware for local runs but your Vulkan expertise is vital here
All reactions