opencl: initial q8_0 mv support
#15732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ggml
lhez
commented
Sep 8, 2025
ggml/src/ggml-opencl/ggml-opencl.cpp
Outdated
| extra = new ggml_tensor_extra_cl_q8_0(); | ||
| } else { | ||
| extra = temp_tensor_extras_q8_0.back(); | ||
| temp_tensor_extras_q4_0.pop_back(); |
There was a problem hiding this comment.
Should be temp_tensor_extras_q8_0.pop_back().
lhez
force-pushed
the
q8_0-mv
branch
2 times, most recently
from
9e07767 to
066b21d
Compare
|
@max-krasnyansky @rmatif I am going to merge this to move things forward. We can iterate on this if needed. |
Sorry for the delay. I’ve been pretty busy. I’ll look into this (and the others) today |
|
|
rmatif
approved these changes
Sep 21, 2025
|
@lhez I'll let you merge the PR according to the new guidelines |
|
@rmatif Thank you for taking a look! |
struct
pushed a commit
to struct/llama.cpp
that referenced
this pull request
Sep 26, 2025
yael-works
pushed a commit
to yael-works/llama.cpp
that referenced
this pull request
Oct 15, 2025
pwilkin
pushed a commit
to pwilkin/llama.cpp
that referenced
this pull request
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial
q8_0support.