cuda/vulkan : bicubic interpolation #17022
Open
+139
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acly
requested review from
0cc4m,
lhez,
max-krasnyansky and
slaren
as code owners
github-actions
bot
added
testing
Collaborator
|
Thank you, looks good for OpenCL. |
slaren
approved these changes
Nov 8, 2025
tests/test-backend-ops.cpp
Outdated
| test_cases.emplace_back(new test_interpolate(GGML_TYPE_F32, {1, 4, 3, 2}, {2, 8, 3, 2}, GGML_SCALE_MODE_BILINEAR | GGML_SCALE_FLAG_ALIGN_CORNERS)); | ||
| test_cases.emplace_back(new test_interpolate(GGML_TYPE_F32, {4, 1, 3, 2}, {1, 1, 3, 2}, GGML_SCALE_MODE_BILINEAR | GGML_SCALE_FLAG_ALIGN_CORNERS)); | ||
| for (ggml_scale_mode mode : {GGML_SCALE_MODE_BILINEAR, GGML_SCALE_MODE_BICUBIC}) { | ||
| test_cases.emplace_back(new test_interpolate(GGML_TYPE_F32, {2, 5, 7, 11}, {5, 7, 11, 13}, mode | GGML_SCALE_FLAG_ALIGN_CORNERS)); |
Member
There was a problem hiding this comment.
Suggested change
| test_cases.emplace_back(new test_interpolate(GGML_TYPE_F32, {2, 5, 7, 11}, {5, 7, 11, 13}, mode | GGML_SCALE_FLAG_ALIGN_CORNERS)); | |
| test_cases.emplace_back(new test_interpolate(GGML_TYPE_F32, {2, 5, 7, 11}, {5, 7, 11, 13}, mode | GGML_SCALE_FLAG_ALIGN_CORNERS)); |
CISC
reviewed
Nov 8, 2025
ggml/src/ggml-vulkan/ggml-vulkan.cpp
Outdated
| case GGML_SCALE_MODE_BILINEAR: | ||
| return ctx->device->pipeline_upscale_bilinear_f32; | ||
| case GGML_SCALE_MODE_BICUBIC: | ||
| return ctx->device->pipeline_upscale_bicubic_f32; |
Collaborator
There was a problem hiding this comment.
Suggested change
| return ctx->device->pipeline_upscale_bicubic_f32; | |
| return ctx->device->pipeline_upscale_bicubic_f32; |
…tests * adapt OpenCL backend to not support the OP in that case so tests don't fail
Collaborator
Author
|
Fixed the whitespace issues. Also did a rebase, which should fix the test-thread-safety issue from last CI run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend support for
GGML_OP_UPSCALEwithGGML_SCALE_MODE_BICUBICggml_backend_supports_opto return false for bicubicCombined PR so I can add backend-ops tests without having them fail for some backends.