Skip to content

ggml webgpu: add support for emscripten builds #17184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 3, 2025
Merged

ggml webgpu: add support for emscripten builds #17184

merged 11 commits into from
Dec 3, 2025
+355 −139

Conversation

@reeselevine
Copy link
Collaborator

@reeselevine reeselevine commented Nov 12, 2025

This PR builds on and supersedes #15826 from @ngxson.

  • Adds __EMSCRIPTEN__ preprocessors conditionals in places necessary for compilation (this included some OS specific things in common/
  • Adds flags for emscripten builds for 64-bit memory, memory growth that I found to be required to get the backend operations to pass when running through the browser (Chrome/M3 system)
  • Also adds a Github workflow that ensures emscripten builds compile (at least with test-backend-ops), to avoid other code additions that accidentally break things.
  • Disables dawn/native-only WebGPU features when building for the browser, like experimental support for subgroup matrices

reeselevine and others added 4 commits November 5, 2025 08:24
@reeselevine
Faster tensors (#8)
c6bc125 
Add fast matrix and matrix/vector multiplication.
@reeselevine
Use map for shader replacements instead of pair of strings
7c2b2ef
@reeselevine @ngxson
Wasm (#9)
c201d0d 
* webgpu : fix build on emscripten

* more debugging stuff

* test-backend-ops: force single thread on wasm

* fix single-thread case for init_tensor_uniform

* use jspi

* add pthread

* test: remember to set n_thread for cpu backend

* Add buffer label and enable dawn-specific toggles to turn off some checks

* Intermediate state

* Fast working f16/f32 vec4

* Working float fast mul mat

* Clean up naming of mul_mat to match logical model, start work on q mul_mat

* Setup for subgroup matrix mat mul

* Basic working subgroup matrix

* Working subgroup matrix tiling

* Handle weirder sg matrix sizes (but still % sg matrix size)

* Working start to gemv

* working f16 accumulation with shared memory staging

* Print out available subgroup matrix configurations

* Vectorize dst stores for sg matrix shader

* Gemv working scalar

* Minor set_rows optimization (#4)

* updated optimization, fixed errors

* non vectorized version now dispatches one thread per element

* Simplify

* Change logic for set_rows pipelines

---------

Co-authored-by: Neha Abbas <nehaabbas@macbookpro.lan>
Co-authored-by: Neha Abbas <nehaabbas@ReeseLevines-MacBook-Pro.local>
Co-authored-by: Reese Levine <reeselevine1@gmail.com>

* Comment on dawn toggles

* Working subgroup matrix code for (semi)generic sizes

* Remove some comments

* Cleanup code

* Update dawn version and move to portable subgroup size

* Try to fix new dawn release

* Update subgroup size comment

* Only check for subgroup matrix configs if they are supported

* Add toggles for subgroup matrix/f16 support on nvidia+vulkan

* Make row/col naming consistent

* Refactor shared memory loading

* Move sg matrix stores to correct file

* Working q4_0

* Formatting

* Work with emscripten builds

* Fix test-backend-ops emscripten for f16/quantized types

* Use emscripten memory64 to support get_memory

* Add build flags and try ci

---------

Co-authored-by: Xuan Son Nguyen <son@huggingface.co>
@reeselevine
Merge remote-tracking branch 'upstream/master'
6db7298
@DajanaV DajanaV mentioned this pull request Nov 12, 2025
Open
@github-actions github-actions bot added build Compilation issues script Script related testing Everything test related devops improvements to build systems and github actions ggml changes relating to the ggml tensor library for machine learning labels Nov 12, 2025
slaren
slaren reviewed Nov 13, 2025
View reviewed changes
@reeselevine
Copy link
Collaborator Author

reeselevine commented Nov 27, 2025

Looking for a review/approval on this @slaren or @ngxson (or someone else if you think they are better suited to review). Thank you!

ngxson
ngxson reviewed Nov 27, 2025
View reviewed changes
@reeselevine
Copy link
Collaborator Author

reeselevine commented Dec 3, 2025

@ngxson @slaren is there anything else needed here for approval? I'd like to try and get this merged so I can start opening some other PRs/get the code to avoid emscripten builds from breaking into the mainline.

ngxson
ngxson approved these changes Dec 3, 2025
View reviewed changes
Copy link
Collaborator

@ngxson ngxson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now, thanks!

@ngxson ngxson merged commit 7ca5991 into ggml-org:master Dec 3, 2025
72 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slaren slaren slaren left review comments

@ngxson ngxson ngxson approved these changes

@ggerganov ggerganov Awaiting requested review from ggerganov ggerganov is a code owner

@CISC CISC Awaiting requested review from CISC CISC is a code owner

Assignees

No one assigned

Labels

build Compilation issues devops improvements to build systems and github actions ggml changes relating to the ggml tensor library for machine learning script Script related testing Everything test related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reeselevine @slaren @ngxson