opencl: add sqr, sqrt, mean and ssm_conv #17476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@lhez It's time to update |
github-actions
bot
added
ggml
lhez
force-pushed
the
lh/sqr-sqrt-mean-ssm-conv
branch
from
253dd70 to
338d9ac
Compare
max-krasnyansky
approved these changes
Nov 26, 2025
Collaborator
max-krasnyansky
left a comment
max-krasnyansky
left a comment
There was a problem hiding this comment.
Very nice!
SSM_CONV in particular gives a nice perf boost for the LFM2 models.
LFM2-1.2B-Q4_0.gguf
Before:
common_perf_print: prompt eval time = 286.12 ms / 212 tokens ( 1.35 ms per token, 740.95 tokens per second)
common_perf_print: eval time = 966.67 ms / 50 runs ( 19.33 ms per token, 51.72 tokens per second)
After:
common_perf_print: prompt eval time = 250.62 ms / 212 tokens ( 1.18 ms per token, 845.91 tokens per second)
common_perf_print: eval time = 1126.55 ms / 63 runs ( 17.88 ms per token, 55.92 tokens per second)
I checked the SCHED_DEBUG output and we now claim all the SSM_CONV ops in LFM2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add new ops - sqr, sqrt, mean and ssm_conv needed by models like gemma3n and lfm2 models.