vulkan : move contiguous checks to device_supports_op #17490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in device_supports_op
github-actions
bot
added
Vulkan
Acly
changed the title
jeffbolznv
reviewed
Nov 25, 2025
Collaborator
jeffbolznv
left a comment
jeffbolznv
left a comment
There was a problem hiding this comment.
I spot checked several ops but didn't look at all of the shaders to verify whether they require contiguous.
ggml/src/ggml-vulkan/ggml-vulkan.cpp
Outdated
| && ggml_is_contiguous(op->src[1]) && op->src[1]->type == GGML_TYPE_I32; | ||
| case GGML_OP_IM2COL: | ||
| return ggml_is_contiguous(op->src[0]) && ggml_is_contiguous(op->src[1]) | ||
| && (op->src[0]->type == GGML_TYPE_F32 || op->src[0]->type == GGML_TYPE_F16) |
Collaborator
There was a problem hiding this comment.
I think src0 type doesn't matter for im2col(3d), it's only used to provide the filter shape.
Collaborator
Author
There was a problem hiding this comment.
Right, I removed the constraints on src0
Collaborator
Author
I did look at all the shaders, and checked that test-backend-ops doesn't skip anything it didn't skip before. Though there's still a slight risk I accidentaly overconstrained something here. |
jeffbolznv
approved these changes
Nov 26, 2025
0cc4m
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ggml_vk_op_supports_incontiguous, by now its sole purpose was aborting for unsupported tensor stridesggml_backend_vk_device_supports_opfor ops that were missing themThis should play nice with backend scheduler and test-backend-ops.