docs: clarify that CPU support should be first #17886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngxson
approved these changes
Dec 9, 2025
CONTRIBUTING.md
Outdated
| - If you modified the `ggml` source, run the `test-backend-ops` tool to check whether different backend implementations of the `ggml` operators produce consistent results (this requires access to at least two different `ggml` backends) | ||
| - If you modified a `ggml` operator or added a new one, add the corresponding test cases to `test-backend-ops` | ||
| - Create separate PRs for each feature or fix. Avoid combining unrelated changes in a single PR | ||
| - When adding support for a new model or feature, focus on *CPU support only** in the initial PR unless you have a good reason not to. Add support for other backends like CUDA in follow-up PRs |
Collaborator
There was a problem hiding this comment.
(missing an asterisk * to make it bold text)
JohannesGaessler
force-pushed
the
doc-update
branch
from
1ab62c1 to
f2fad65
Compare
ggerganov
approved these changes
Dec 9, 2025
Ethan-a2
pushed a commit
to Ethan-a2/llama.cpp
that referenced
this pull request
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies that contributors should focus on adding CPU support first before branching out to other backends. That makes it I think much easier for ggml backend maintainers to review the related changes.