cmake: link ws2_32 for MinGW/w64devkit builds in cpp-httplib #17949
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngxson
approved these changes
Dec 12, 2025
ggerganov
reviewed
Dec 12, 2025
Comment on lines
+13
to
+15
| if (WIN32 AND NOT MSVC) | ||
| target_link_libraries(${TARGET} PUBLIC ws2_32) | ||
| endif() |
Member
There was a problem hiding this comment.
In case PRIVATE linkage is enough, consider changing this to reduce public scope pollution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small linker fix to allow the procedure described in build.md to work correctly using w64devkit.
Missing link found with Claude and corrected with Gemini.