gguf-py: Add requests to dependencies#18629
Merged
CISC merged 1 commit intoggml-org:masterfrom Jan 6, 2026
Merged
Conversation
taronaeo
approved these changes
Jan 6, 2026
CISC
approved these changes
Jan 6, 2026
Collaborator
CISC
left a comment
There was a problem hiding this comment.
Not sure we need to stay dependency compatible all the way down to version 2.25, but I guess it's fine.
Collaborator
Author
just for context, I saw the Python |
Collaborator
Also for context, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's used here:
llama.cpp/gguf-py/gguf/utility.py
Lines 220 to 226 in e443fbc
Or maybe an optional dependency would suffice?