Skip to content

gguf-py: Add requests to dependencies#18629

Merged
CISC merged 1 commit intoggml-org:masterfrom
ckastner:python-requests
Jan 6, 2026
Merged

gguf-py: Add requests to dependencies#18629
CISC merged 1 commit intoggml-org:masterfrom
ckastner:python-requests

Conversation

@ckastner
Copy link
Collaborator

@ckastner ckastner commented Jan 5, 2026

It's used here:

@classmethod
def get_data_by_range(cls, url: str, start: int, size: int = -1) -> bytes:
"""
Get raw byte data from a remote file by range.
If size is not specified, it will read the entire file.
"""
import requests

Or maybe an optional dependency would suffice?

Copy link
Collaborator

@CISC CISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we need to stay dependency compatible all the way down to version 2.25, but I guess it's fine.

@CISC CISC merged commit bd2a93d into ggml-org:master Jan 6, 2026
2 checks passed
@ckastner
Copy link
Collaborator Author

ckastner commented Jan 6, 2026

Not sure we need to stay dependency compatible all the way down to version 2.25, but I guess it's fine.

just for context, I saw the Python >= 3.8 and thought I should also pick something older here, so I arbitrarily picked the oldest version still supported by Debian.

@CISC
Copy link
Collaborator

CISC commented Jan 6, 2026

Not sure we need to stay dependency compatible all the way down to version 2.25, but I guess it's fine.

just for context, I saw the Python >= 3.8 and thought I should also pick something older here, so I arbitrarily picked the oldest version still supported by Debian.

Also for context, Python >= 3.8 is probably a lie. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python python script changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants