fix(ggml): correct RISC-V ISA string canonical ordering for RVV in CMake#20888
Merged
ggerganov merged 1 commit intoggml-org:masterfrom Mar 26, 2026
Merged
Conversation
github-actions
Bot
added
the
ggml
ggerganov
reviewed
Mar 23, 2026
Signed-off-by: ihb2032 <hebome@foxmail.com>
ihb2032
force-pushed
the
fix/riscv-isa-canonical-order
branch
from
b5f11ad to
05d5810
Compare
xctan
approved these changes
Mar 26, 2026
slartibardfast
pushed a commit
to slartibardfast/llama.cpp
that referenced
this pull request
Apr 12, 2026
…ake (ggml-org#20888) Signed-off-by: ihb2032 <hebome@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When configuring the CMake build for RISC-V with both standard vector extensions
GGML_RVVand multi-letter extensions, the generated-marchstring violates the RISC-V ISA canonical ordering rules.Currently, the single-letter
vextension is appended after the multi-letterzextensions, e.g., resulting inrv64gc_zfh_v.... Modern, strict compilers reject this non-canonical ISA string and fail to build the CPU backend with:error: unexpected ISA string at end: ‘v_zvfh_zicbop_zihintpause’Testing
Verified successful compilation on RISC-V using GCC 14.2 with
-DGGML_RVV=ONand-DGGML_RV_ZFH=ON.Make sure to read the contributing guidelines before submitting a PR