Skip to content

requirements : update transformers to 5.5.0#21617

Merged
CISC merged 8 commits intoggml-org:masterfrom
danbev:transformers-update
Apr 9, 2026
Merged

requirements : update transformers to 5.5.0#21617
CISC merged 8 commits intoggml-org:masterfrom
danbev:transformers-update

Conversation

@danbev
Copy link
Copy Markdown
Member

@danbev danbev commented Apr 8, 2026

Overview

This commit updates the transformers dependency to version 5.5.0.

The motivation for this is that transformers 5.5.0 includes support for Gemma4 and is required to be able to convert Gemma4 models. This is also causing issues for user of gguf-my-repo.

Refs: https://huggingface.co/spaces/ggml-org/gguf-my-repo/discussions/202


This commit updates the transformers dependency to version 5.5.0.

The motivation for this is that transformers 5.5.0 includes support for
Gemma4 and is required to be able to convert Gemma4 models. This is also
causing issues for user of gguf-my-repo.

Refs: https://huggingface.co/spaces/ggml-org/gguf-my-repo/discussions/202
@danbev danbev requested a review from CISC as a code owner April 8, 2026 10:13
Copy link
Copy Markdown
Member

@CISC CISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope we've ironed out all the issues with 5.x by now. :)

danbev added 2 commits April 9, 2026 06:44
This commit adds `ty: ignore` directives to transformers tokenizers
field/methods to avoid type check errors. There might be better ways to
handle this and perhaps this can be done in a follow up commit.

The motivation for this is that it looks like in transformers 5.5.0
AutoTokenizer.from_pretrained can return generic tokenizer types or None
and the type checker now produces an error when the conversion script
accesses field like tokenizer.vocab.
@danbev danbev requested a review from ggerganov as a code owner April 9, 2026 05:09
@danbev danbev removed the request for review from ggerganov April 9, 2026 05:44
@CISC
Copy link
Copy Markdown
Member

CISC commented Apr 9, 2026

@danbev Sigh, all the typings errors need a better fix than just ignoring them, but I guess it's best left as a follow up.

I was running a newer version of ty locally but I've switched to
version 0.0.26 which is what CI uses and I was then able to reproduce
the errors. Sorry about the noise.
@danbev
Copy link
Copy Markdown
Member Author

danbev commented Apr 9, 2026

Sigh, all the typings errors need a better fix than just ignoring them, but I guess it's best left as a follow up.

Yeah, I agree. Lets get this merged and then we can update gguf-my-repo so it is hopefully working again and I'll look at a proper fix for this. I was using newer version of ty locally which is why there was so much back and forth. Hopefully I've got this right with the last commit.

@github-actions github-actions bot added testing Everything test related examples python python script changes server labels Apr 9, 2026
Copy link
Copy Markdown
Member

@CISC CISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[no ci] this

@CISC CISC merged commit c8ac02f into ggml-org:master Apr 9, 2026
1 check passed
spiritbuun pushed a commit to spiritbuun/buun-llama-cpp that referenced this pull request Apr 9, 2026
* requirements : update transformers to 5.5.0

This commit updates the transformers dependency to version 5.5.0.

The motivation for this is that transformers 5.5.0 includes support for
Gemma4 and is required to be able to convert Gemma4 models. This is also
causing issues for user of gguf-my-repo.

Refs: https://huggingface.co/spaces/ggml-org/gguf-my-repo/discussions/202

* fix huggingface_hub version

* set version of transformers to 5.5.0

* convert : add ty ignore directives to convert_hf_to_gguf.py

This commit adds `ty: ignore` directives to transformers tokenizers
field/methods to avoid type check errors. There might be better ways to
handle this and perhaps this can be done in a follow up commit.

The motivation for this is that it looks like in transformers 5.5.0
AutoTokenizer.from_pretrained can return generic tokenizer types or None
and the type checker now produces an error when the conversion script
accesses field like tokenizer.vocab.

* convert : add ty ignore to suppress type check errors

* convert : remove incorrect type ignores

* convert : fix remaining python checks

I was running a newer version of ty locally but I've switched to
version 0.0.26 which is what CI uses and I was then able to reproduce
the errors. Sorry about the noise.

* update transformers version to 5.5.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples python python script changes server testing Everything test related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants