Skip to content

convert : force f16 or f32 on step3-vl conv weights#21646

Merged
CISC merged 1 commit intomasterfrom
cisc/convert-step3vl-conv-tensors-fix
Apr 12, 2026
Merged

convert : force f16 or f32 on step3-vl conv weights#21646
CISC merged 1 commit intomasterfrom
cisc/convert-step3vl-conv-tensors-fix

Conversation

@CISC
Copy link
Copy Markdown
Member

@CISC CISC commented Apr 8, 2026

Overview

cont #21287
fixes #21287 (comment)

Additional information

The conv weights need to be forced to F16 or F32 to be able to perform the IM2COL op.

Requirements

@CISC CISC requested a review from ngxson April 8, 2026 19:48
@CISC
Copy link
Copy Markdown
Member Author

CISC commented Apr 10, 2026

@ngxson gentle ping

@CISC
Copy link
Copy Markdown
Member Author

CISC commented Apr 12, 2026

@ngxson ping

@ngxson
Copy link
Copy Markdown
Contributor

ngxson commented Apr 12, 2026

CC @ggml-org/maintainers for the 2nd approval

@CISC CISC merged commit 1e9d771 into master Apr 12, 2026
8 of 9 checks passed
@CISC CISC deleted the cisc/convert-step3vl-conv-tensors-fix branch April 12, 2026 17:22
crodjer added a commit to crodjer/llama.cpp that referenced this pull request Apr 13, 2026
* origin/master:
  webui: MCP Diagnostics improvements (ggml-org#21803)
  Remove extra conditional check on debug mode. (ggml-org#21798)
  sycl: disable Q1_0 in backend and cleanup unused variables (ggml-org#21807)
  mtmd: fix crash when sending image under 2x2 pixels (ggml-org#21711)
  mtmd: qwen3 audio support (qwen3-omni and qwen3-asr) (ggml-org#19441)
  convert : force f16 or f32 on step3-vl conv weights (ggml-org#21646)
  mtmd: add gemma 4 test (vision + audio) [no ci] (ggml-org#21806)
  mtmd: add Gemma 4 audio conformer encoder support (ggml-org#21421)
  fix: Proper messages rendering for "Show raw output" (ggml-org#21672)
  docs: add guide on how to add multimodal support (ggml-org#21778)
@sebagallo
Copy link
Copy Markdown

sebagallo commented Apr 13, 2026

bf16 mmproj now works!

HermestoAizales pushed a commit to HermestoAizales/llama.cpp that referenced this pull request Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants