Skip to content

fix: Fix broken structured output when using $refs in json_schema#21699

Merged
aldehir merged 3 commits intoggml-org:masterfrom
Galunid:fix-enum-json-output
Apr 10, 2026
Merged

fix: Fix broken structured output when using $refs in json_schema#21699
aldehir merged 3 commits intoggml-org:masterfrom
Galunid:fix-enum-json-output

Conversation

@Galunid
Copy link
Copy Markdown
Contributor

@Galunid Galunid commented Apr 9, 2026

Overview

Fixes #20178

Additional information

$refs in json schema were resolved only for tool calls, now they're also resolved when using response_format

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: Yes, AI debugged the code and wrote the fix, human verified it works, reviewed the change and made cosmetic fixes

@Galunid Galunid requested a review from a team as a code owner April 9, 2026 22:50
@aldehir
Copy link
Copy Markdown
Contributor

aldehir commented Apr 10, 2026

Remove addition to parsers that have no support for response_format.

@Galunid
Copy link
Copy Markdown
Contributor Author

Galunid commented Apr 10, 2026

@aldehir Thanks for the review, I addressed your comments. Is there a technical reason those other models don't support response_format, or is it because nobody implemented it yet?

@aldehir
Copy link
Copy Markdown
Contributor

aldehir commented Apr 10, 2026

@Galunid, no one has implemented it yet. It shouldn't be hard, but that can be done in separate PRs.

Thanks!

cc @pwilkin

@aldehir aldehir merged commit b136b62 into ggml-org:master Apr 10, 2026
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misc. bug: structured json fails when using enums with Qwen3.5-35B-A3B

3 participants