fix: Fix broken structured output when using $refs in json_schema#21699
Merged
aldehir merged 3 commits intoggml-org:masterfrom Apr 10, 2026
Merged
fix: Fix broken structured output when using $refs in json_schema#21699aldehir merged 3 commits intoggml-org:masterfrom
aldehir merged 3 commits intoggml-org:masterfrom
Conversation
aldehir
requested changes
Apr 10, 2026
Contributor
|
Remove addition to parsers that have no support for |
Contributor
Author
|
@aldehir Thanks for the review, I addressed your comments. Is there a technical reason those other models don't support |
Contributor
aldehir
approved these changes
Apr 10, 2026
pwilkin
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #20178
Additional information
$refs in json schema were resolved only for tool calls, now they're also resolved when using response_format
Requirements