common: Refactoring sampler parameters (#20429)#22233
Merged
pwilkin merged 1 commit intoggml-org:masterfrom Apr 22, 2026
Merged
common: Refactoring sampler parameters (#20429)#22233pwilkin merged 1 commit intoggml-org:masterfrom
pwilkin merged 1 commit intoggml-org:masterfrom
Conversation
This change refactors the reasoning_budget_message parameter from the common params into the sampling parameters specifically. It also removes the reasoning_budget common parameter and standardizes on the existing reasoning_budget_tokens parameter in the sampling configuration. Issue: ggml-org#20429 Original PR: ggml-org#20297
Contributor
Author
|
Note that reasoning_budget was an int and reasoning_budget_tokens is int32_t |
pwilkin
approved these changes
Apr 22, 2026
Member
pwilkin
left a comment
pwilkin
left a comment
There was a problem hiding this comment.
Oh yeah, forgot about it. Thanks for this :)
ggerganov
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This change refactors the reasoning_budget_message parameter from the common params into the sampling parameters specifically. It also removes the reasoning_budget common parameter and standardizes on the existing reasoning_budget_tokens parameter in the sampling configuration.
Additional information
Issue: #20429
Original PR: #20297
Requirements