webui: support video files as input#22830
Merged
Merged
Conversation
Contributor
|
IMO this can be an acceptable stop-gap solution. But just one concern is that we will eventually have native video support in mtmd, so we should make sure changes from this PR can be easily reverted when it happens. |
Contributor
Author
|
This is for mtmd (see the issue #20741). Why this needs to be reverted when video support in mtmd is ready? |
Contributor
|
Please rebase this on latest commit on |
ServeurpersoCom
approved these changes
May 16, 2026
Contributor
ServeurpersoCom
left a comment
There was a problem hiding this comment.
LGTM, video has been added symmetrically to image and audio.
If refactor is required, all three can be maintained in the same way.
allozaur
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Support adding video files as input. This can fix #20741.
Everything is done almost the same as audio files.
Detailed Modifications
ChatAttachmentsListItemThumbnailFile) likeChatAttachmentsPreviewThumbnailStrip;input_video(just likeinput_audiofor audio files);mp4andogg);videotoModalities.Test & Sceenshots
I have tested this with chatllm.cpp.
Additional information
Some findings or thoughts that are out of the scope of this PR.
Requirements