ui: Add request timeout for MCP tool calls#23138
Merged
allozaur merged 2 commits intoMay 16, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a per-request timeout to MCP tool calls in the WebUI, fixing the issue where long-running tool calls were canceled after the SDK's default ~60 second timeout instead of honoring the configured 5-minute DEFAULT_MCP_CONFIG.requestTimeoutSeconds.
Changes:
- Adds a
requestTimeoutMsfield to theMCPConnectiontype so each established connection carries its effective request timeout. - Populates
requestTimeoutMson the connection object fromserverConfig.requestTimeoutMs(falling back to the default 5 minutes). - Passes
timeout: connection.requestTimeoutMstoclient.callToolso the MCP SDK uses the configured timeout instead of its built-in default.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/ui/src/lib/types/mcp.d.ts | Adds requestTimeoutMs field to the MCPConnection interface. |
| tools/ui/src/lib/services/mcp.service.ts | Sets requestTimeoutMs on the connection (with default fallback) and forwards it as the timeout option to callTool. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Is this setting configurable in the WebUI settings? |
Contributor
Author
nope, but I can add it :) |
ggerganov
approved these changes
May 16, 2026
ggerganov
approved these changes
May 16, 2026
ServeurpersoCom
approved these changes
May 16, 2026
xxmustafacooTR
pushed a commit
to xxPlayground/llama-cpp-turboquant
that referenced
this pull request
May 16, 2026
* feat: Add request timeout for MCP tool calls in llama-ui * feat: MCP Settings tab with max timeout setting
kgrama
pushed a commit
to kgrama/llama.cpp
that referenced
this pull request
May 19, 2026
* feat: Add request timeout for MCP tool calls in llama-ui * feat: MCP Settings tab with max timeout setting
rsenthilkumar6
pushed a commit
to rsenthilkumar6/llama.cpp
that referenced
this pull request
May 19, 2026
* feat: Add request timeout for MCP tool calls in llama-ui * feat: MCP Settings tab with max timeout setting
ArberSephirotheca
pushed a commit
to ArberSephirotheca/llama.cpp
that referenced
this pull request
May 19, 2026
* feat: Add request timeout for MCP tool calls in llama-ui * feat: MCP Settings tab with max timeout setting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds default 5 minute timeout configuration to tool calls + new settings tab — MCP /
/mcpwith this setting as a numeric field.Close #21368
Additional information
Requirements