Skip to content

vulkan: Removed unused function#23175

Merged
0cc4m merged 2 commits into
ggml-org:masterfrom
winstonma:cleanup/unused-functions
Jun 1, 2026
Merged

vulkan: Removed unused function#23175
0cc4m merged 2 commits into
ggml-org:masterfrom
winstonma:cleanup/unused-functions

Conversation

@winstonma
Copy link
Copy Markdown
Contributor

Overview

Name Status
ggml_vk_create_binary_semaphore Never called
ggml_vk_create_event Never called
ggml_vk_reset_event Never called
ggml_vk_end_submission Never called
ggml_vk_buffer_write_nc_async Never called
ggml_vk_print_tensor_area (5-arg) Shadowed by 6-arg version
ggml_vk_test_dequant Never called
ggml_backend_vk_host_buffer_name Never registered/called

Just clean up

Additional information

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: Yes, finding and removing the unused function

@winstonma winstonma requested a review from a team as a code owner May 17, 2026 01:16
@github-actions github-actions Bot added Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels May 17, 2026
@0cc4m
Copy link
Copy Markdown
Contributor

0cc4m commented May 17, 2026

I don't think just looking at what is used and what isn't is good enough, some of these may still become useful in the future. Having them isn't a problem in itself.

The only really valid one in your list might be ggml_vk_end_submission. ggml_vk_print_tensor_area is not shadowed, just a different variant between GGML_VK_RUN_TESTS and GGML_VK_CHECK_RESULTS.

@winstonma
Copy link
Copy Markdown
Contributor Author

Should I update the branch so that only ggml_vk_end_submission is removed? Thanks

@0cc4m
Copy link
Copy Markdown
Contributor

0cc4m commented May 26, 2026

Yeah, you can remove ggml_vk_end_submission and ggml_backend_vk_host_buffer_name

@winstonma
Copy link
Copy Markdown
Contributor Author

Functions other than ggml_vk_end_submission and ggml_backend_vk_host_buffer_name is restored

@0cc4m
Copy link
Copy Markdown
Contributor

0cc4m commented Jun 1, 2026

@ggml-org/maintainers Another approval needed.

@0cc4m 0cc4m merged commit f8c0a19 into ggml-org:master Jun 1, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning Vulkan Issues specific to the Vulkan backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants