server: fix --cache-ram not preventing RAM OOM#23561
Open
zzhenyao wants to merge 2 commits into
Open
Conversation
Author
|
@aldehir @ggerganov could you please take a look when convenient? Follow-up: if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix RAM OOM crash in
server_prompt_cachewhen saving prompt cache with--cache-ramlimit.A previous fix added pre-allocation checks, but checkpoint data was not included in the cache size calculation, so the real cache size could still exceed
--cache-ram.Also,
update()did not account for the pending allocation, and thestates.size() > 1guard skipped eviction when only one entry existed.Fixed:
update()so it evicts until the new entry fitsstates.size() > 1guardcatch(bad_alloc)recoveryAdditional information
alloc()checked the limit using only KV cache and draft state sizes, and thetryblock only allocated those. But the cache entry also included checkpoint data, so actual RAM usage could still exceed the configured limit and trigger OOM.Before fix:
After fix:
Requirements