graph : ensure DS32 kq_mask_lid is F32#23864
Open
CISC wants to merge 1 commit into
Open
Conversation
Contributor
|
Does this mask need to be f32? |
Member
Author
Either that or we have to cast |
am17an
approved these changes
May 29, 2026
Collaborator
|
So... I checked how DeepSeek V3.2 works in master (a couple of hours too late) and ended up here. But this PR helps, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
cont #23346
cont #23764
Additional information
Since
build_attn_inp_kq_maskreturnsF16mask when flash attention is enabled, pass a modified copy ofcparamsforkq_mask_lid.llama.cpp/src/models/deepseek32.cpp
Lines 341 to 344 in 1f0aa2a
This is a bit hacky, open for better solutions. cc/ @am17an
Requirements