[ggml-webgpu] Handle buffer overlap / buffer aliasing for concat operator#24000
Merged
reeselevine merged 22 commits intoJun 8, 2026
Merged
Conversation
# Conflicts: # .github/workflows/build.yml
# Conflicts: # .github/workflows/build.yml
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Hi @nikhilJain17, thanks for working on this, and it all looks great! LGTM |
yomaytk
approved these changes
Jun 2, 2026
reeselevine
reviewed
Jun 3, 2026
reeselevine
approved these changes
Jun 5, 2026
CISC
approved these changes
Jun 5, 2026
| shader_lib_ctx.src1 = nullptr; | ||
| shader_lib_ctx.dst = dst; | ||
| shader_lib_ctx.max_wg_size = ctx->global_ctx->capabilities.limits.maxComputeInvocationsPerWorkgroup; | ||
| shader_lib_ctx.max_wg_size = ctx->global_ctx->capabilities.limits.maxComputeInvocationsPerWorkgroup; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
While testing the WebGPU backend with stable-diffusion.cpp, I encountered the following error:
Since WebGPU does not allow a read bind and a write bind on the same buffer, there was a workaround to merge two overlapping
srcbuffers into amerged_srcbuffer in #22456. This diff applies the same technique to theconcatshader.cc @yomaytk
Requirements