cmake: skip cvector-generator and export-lora when CPU backend is disabled#24053
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Tightens the build conditions for certain tools/examples so they are only included when the CPU backend is enabled (in addition to requiring non-dynamic backend loading).
Changes:
- Restrict
cvector-generatorandexport-lorasubdirectories to build only whenGGML_CPUis enabled andGGML_BACKEND_DLis disabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Bad merge. |
Contributor
Author
|
Sorry let me rebase - fixed ✔️ |
0b22e90 to
516bd6e
Compare
CISC
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Both
cvector-generatorandexport-loralink against CPU backend symbols (ggml_backend_cpu_init,ggml_get_f32_nd, etc.) unconditionally. When building with-DGGML_CPU=OFF, these tools fail tolink, causing
cmake --installto error on a missing binary:Both tools are guarded by
NOT GGML_BACKEND_DLbut not byGGML_CPU. Added the missing check.Requirements