ci : add gatekeeper workflow for manual approval on non-master branches#33
Merged
Conversation
- Add reusable gatekeeper.yml workflow with two paths: - Auto-approve on master branch - Require 'ci-manual' environment approval on non-master branches - Wire build.yml through the gatekeeper as first example Assisted-by: llama.cpp:local pi
Member
|
Oh, nice. |
Member
Author
|
Yeah, I think we can even split the gatekeepers into sections (e.g. main, cuda, metal, etc.) and have different teams assigned to approve those. |
Member
Author
|
The auto-approve of the gatekeeper on |
Member
Author
|
I will start implementing the gatekeepers in the main repo. |
Member
Great, with the added affinity we should be able to do more targeted workflow runs. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add a reusable
gatekeeper.ymlworkflow that gates CI runs on non-master branches behind a manual approval step via theci-manualenvironment. On the master branch, the gatekeeper is a no-op (auto-approve).The main
build.ymlis wired through the gatekeeper as the first example. Remaining workflow files will be wired in follow-up PRs.How it works
gatekeeper-autojob runs immediately — no delaygatekeeper-reviewjob pauses and waits for manual approval from a reviewer assigned to theci-manualenvironmentAll downstream jobs use
needs: [gatekeeper]so nothing runs until the gatekeeper clears.Setup required
The
ci-manualenvironment must be created in Settings → Environments with at least one required reviewer before non-master CI runs can proceed.Requirements