Skip to content

Feat: allow Observer.url#189

Merged
StoicLoofah merged 2 commits into
ggtracker:upstreamfrom
NumberPigeon:Observer-url
Sep 1, 2023
Merged

Feat: allow Observer.url#189
StoicLoofah merged 2 commits into
ggtracker:upstreamfrom
NumberPigeon:Observer-url

Conversation

@NumberPigeon

Copy link
Copy Markdown
Contributor

Before this commit:

>>> o
Observer 4 - EnObsB
>>> o.url
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/daydrm/CodePlayground/python/sc2reader/sc2reader/objects.py", line 293, in url
    return self.URL_TEMPLATE.format(
           ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'region_id'

After this commit:

>>> o = r.observer[4]
>>> o.url
'https://starcraft2.com/en-us/profile/2/1/10400173'

Comment thread sc2reader/objects.py Outdated
Co-authored-by: Christian Clauss <cclauss@me.com>
@StoicLoofah StoicLoofah merged commit f3744fe into ggtracker:upstream Sep 1, 2023
@NumberPigeon NumberPigeon deleted the Observer-url branch September 4, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants