Skip to content

[directfd] Update DF driver for bugs on multiple opens#2087

Merged
ghaerr merged 1 commit intomasterfrom
df5
Oct 25, 2024
Merged

[directfd] Update DF driver for bugs on multiple opens#2087
ghaerr merged 1 commit intomasterfrom
df5

Conversation

@ghaerr
Copy link
Copy Markdown
Owner

@ghaerr ghaerr commented Oct 25, 2024

Adds per-drive globals (amongst all the other globals) to fix problems identified by @Mellvik in Mellvik/TLVC#95 when a second DF device is opened prior to any I/O requests received for the first device (or vice-versa).

Other changes include:

  • Don't auto-probe floppy on pre-AT systems
  • Group "dual" globals together at top of driver so easy to see
  • Don't display first auto-probe message (as either result or next probe is always displayed)
  • Changed "implied seek" printk to debug only
  • Changed "auto-detected" message to just display floppy type
  • Always disable interrupts before accessing 8237 DMA controller (for shared flip-flop, actually just removes FIXME comment)
  • Fixes small bug disabling next request when invalid FDC command seen (wouldn't happen anyways)

@ghaerr ghaerr merged commit 3a662d6 into master Oct 25, 2024
@ghaerr ghaerr deleted the df5 branch October 25, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant