Conversation
Contributor
|
Thanks! Interesting topic about weak symbols and floating point support. Did not know about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2237.
OWC wlink was failing to link vfprintf.obj in small and compact models due to the mechanism used to make "weak" symbols work using the _weaken macro, because the OWC compiler generates a far segment relocation entry which causes wlink to fail with a "relocation not in same segment" error.
This all happens because vfprintf attempts to be smart about dragging in the large dtostr and ptostr routines into printf when floating point/ptick display aren't used. One fix would be to always link in dtostr in small model OWC programs, which would make them considerably larger, so instead this fix eliminates automatically including dtostr/ptostr entirely, eliminating automatic floating point display using printf %f/%g or %k (ptick) format specifiers. Instead, the application will need to call dtostr or ptostr explicitly if needed.
Also removes /lib/nxworld.map from the image as Nano-X is now built outside of ELKS in the Microwindows repo, and it is installed from there when built.