Added support for different base IO port address for ATA#2349
Closed
toncho11 wants to merge 1 commit intoghaerr:masterfrom
Closed
Added support for different base IO port address for ATA#2349toncho11 wants to merge 1 commit intoghaerr:masterfrom
toncho11 wants to merge 1 commit intoghaerr:masterfrom
Conversation
XT-IDE uses a different base IO address.
Owner
|
I thought @fhendrikx said he already made this change... Can you or @fhendrikx use ATA_BASE_PORT as previously suggested, so as to match other naming conventions already in use? |
Contributor
Yep, I've already got that on my branch, of course, this has not yet pushed. |
Owner
Ok, I'll close this now then, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XT-IDE usually uses 0x300 instead of the standard 0x1F0.