Conversation
Contributor
|
Nice catch for the control port! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ATA-CF driver now supports compilation with CONFIG_FS_XMS enabled, in which case an extra copy is required from the ATA I/O port to a main memory buffer if the system buffer is in XMS. When XMS is disabled, no extra copy is performed.
XMS code only tested on QEMU; updated driver not tested on Solo/86.
Also fixes a CF card recognition problem seen in QEMU previously showing both CF cards present when not actually present. While rewriting the ATA driver function error return code to kernel standard, this problem went away. I think the issue was that the functions previously mixed returning a negative kernel error code, zero and ATA status register bits. The function return value numbers are now all kernel standard, returning negative numbers on errors, zero on success, and not returning status register bits.
It should be noted that block device drivers don't actually ever return any I/O error code to kernel upper layers or to the user, so the only usefulness in tracking I/O error numbers is for driver understanding and debugging.
Various repeated code throughout the driver was combined to reduce kernel code size (e.g. wait while busy, getting ATA status, etc).