[libc] Remove stdio dependencies in linenoise lib#2417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close inspection of the linenoise library reveals it was dragging in stdio, when the primary user /bin/sh doesn't use stdio.
Replaces fgets, fgetc and fread with small internal versions. Also removes atexit() since that was only used for exit protection when in raw mode, and the library won't exit with raw mode enabled.
Some slight source code retabbing.
Saves ~400 bytes from /bin/sh compared to original size prior to linenoise library pulled into C library.