Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kernel startup for task 1 was enhanced to allow for dynamically handling the case when the first task is not /bin/init.
Previously, this required special kernel compilation using CONFIG_SYS_NO_BININIT. Now, the kernel handles this dynamically, which can occur when /bootopts uses init= or /bin/init is missing from the boot image. In addition, the meaning of CONFIG_SYS_NO_BININIT is changed when set in a config file to not copy /bin/init, /bin/getty and /bin/login, resulting in smaller systems, mostly useful for ROM systems.
Discussed in more detail in #2426. This PR also includes several enhancements originally written or conceived by @hexadec1mal in #2426. In particular, @hexadec1mal's ideas or code is used:
:inittag in Applications installation fileThank you @hexadec1mal!
The previous mechanism for disabling auto-reaping of child processes on parent exit when /bin/init is not running was broken.
sashnow callswaitpidto remove zombie processes, which caused an out-of-tasks condition when /bin/sash was run as the init task.Tested on PC builds and
emu86ROM images. Should work on all other images since CONFIG_SYS_NO_BININIT is not set by default for any supported port.