Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BusyELKS "BusyBox"-like clone had bit-rotted for so long it wouldn't even compile. This is because its compilation was set by default to use the CONFIG_APP_xxx defines to set which modules to compile in. Since these are no longer set in any default configuration, it appears it may have been years since this program was compiled or used.
It appears almost all of the "commands" within BusyELKS actually come from sash, except that the sash source code has been bugfixed over the years whereas BusyELKS is completely unmaintained. There isn't much use in using BusyELKS on any system anymore, since sash can do everything it can, also works as a standalone shell, and is actually smaller, since loads of ASCII usage messages aren't included. Also, BusyELKS is hard to use without a filesystem that supports symbolic or hard-links, which means it isn't useful on FAT filesystems used on many CF cards.
Thus I propose that BusyELKS be removed after release v0.9.0. This will also allow considerable cleanup in the elkscmd/Make.install script, which @hexadec1mal did in #2426, but has been delayed.