Conversation
Owner
Author
|
Closing as not needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussed in #2398 (comment) as likely problem for new BIOS retry errors on PC-98 system.
Should fix original PR #2411 by only resetting BIOS using bios_drive_map[] when both ATA CF driver and BIOS HD driver present. While still not optimal, this should fix PC98 issue with BIOS retries since ATA CF driver is not present on PC98.
It appears the original fix #2411 may not work on all systems, more testing on real hardware system may be required.