[kernel] Don't disable interrupts in block device request queue unless async I/O enabled#2515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompted from discussion in #2506 (comment).
Removes special handling of request queue lists when CONFIG_ASYNCIO is not configured. This allows execution of block driver read/writes with interrupts always enabled, which should allow for fast serial input during SD card I/O on systems without the direct floppy driver compiled in.
@swausd: Close inspection showed that the low level block device request queue management routines disabled interrupts while traversing the request queue. When CONFIG_ASYNCIO is not enabled (which is only required by the direct floppy driver when compiled in), the request queue size is 1, and thus no special handling is required.
Tested on IBM PC direct floppy on QEMU, and ROMFS build on emu86.