Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects process exit values returned by
waitpid(..., &status, ...)etc to Linux standard. This now aligns with the WIF* macros in <sys/wait.h>.The standard values for integer value of
statusare:sashwas updated to properly report stopped jobs and the stopping signal number (either SIGSTOP or SIGTSTP for now).The Mar 3 1991 version of
ashELKS is using is hopelessly out of date and is fighting hard not to report on Stopped jobs. Comparison with a later May 4 1995 version has tons of code updates in jobs.c when usingwaitpid(..., WUNTRACED)but unfortunately I've not been able to even get it to compile.Good shell jobs support in ELKS looks pretty grim, since real support needs the addition of SIGTTIN and SIGTTOU signals, along with the missing
tcsetpgrpandtcgetptrpioctls for working with the controlling terminal.