Fix compilation of libfabric backend with Boost 1.87.0 and newer#51
Merged
boeschf merged 1 commit intoghex-org:mainfrom Jan 31, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boost 1.87.0 changed the
consume_onefunction (used byconsume_all) to actually move arguments into the callback (boostorg/lockfree@5e9bc81, specifically this line: https://github.com/boostorg/lockfree/blob/5e9bc81d9c1763861a03811266edb142b797987d/include/boost/lockfree/queue.hpp#L537). This breaks compilation of the libfabric backend in oomph because the callback expects to receive theendpoint_wrapperby l-value reference.This fixes compilation by using a universal reference
auto&&. This allows taking the endpoint wrapper by reference in all cases. Usingendpoint_wrapper&&would fix compilation with Boost 1.87.0, but break it with older versions. Taking it by value would also work with all versions, but introduces an extra move/copy construction. I do like explicitly naming types if possible, but in this case it seems worth the tradeoff to useauto.