Merged
Conversation
Cito
requested changes
Feb 2, 2026
Member
Cito
left a comment
There was a problem hiding this comment.
Looks good, but I agree the name list_multipart_uploads is now misleading.
Why not provide two methods, one like it was before and another one get_all_multipart_uploads that would return a dict with object IDs as values?
I think that is cleaner than a dual-purpose method.
Pull Request Test Coverage Report for Build 21626058637Details
💛 - Coveralls |
Member
Author
|
@Cito I've split the function into two parts as suggested |
Cito
previously approved these changes
Feb 3, 2026
Member
Cito
left a comment
There was a problem hiding this comment.
I would have also kept the old name with _for_object because now you wonder why we have two functions. But with _for_object and get_all_ it will be clear.
Cito
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
list_multipart_uploads()to the protocol and the S3 provider, as well as theInMemObjectStoragetest class. The method takes a bucket ID and, optionally, an object ID. If an object ID is provided, the results are filtered to only show uploads for the specified object ID. The result is adict[str, str]({upload_id: object_id}), which makes the name slightly misleading. Maybe it makes more sense to name itget_multipart_uploads(), or to return a list of 2-tuples.There is no version bump as this is intended to be released in v8.0.0 along with the already-merged DAO index changes.