set model based on its type #257
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HennerM
reviewed
Jul 23, 2020
|
|
||
| body.data.forEach((data: any) => { | ||
| const model: T = this.deserializeModel(modelType, data); | ||
| const model: T = this.deserializeModel(this.datastoreConfig.models[data.type], data); |
Collaborator
There was a problem hiding this comment.
could we still default to modelType though? So that it doesn't fail in the rare case there is no type field?
Author
There was a problem hiding this comment.
yes, looks like it is a good idea
maybe it needs some documentation also, do not remember
anyway we ended up ejecting the library from our projects due to the lack of responsiveness to our PRs
so I do not feel like continuing with this one. I gonna close the PRs
thank you for your comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, it is suitable to have subtypes of the model.
For example, the Author and Consumer both extend User. So
/usersendpoint serves heterogeneous types.