Skip to content

set model based on its type #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

set model based on its type #257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/angular2-jsonapi/src/services/json-api-datastore.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ export class JsonApiDatastore {
const models: T[] = [];

body.data.forEach((data: any) => {
const model: T = this.deserializeModel(modelType, data);
const model: T = this.deserializeModel(this.datastoreConfig.models[data.type], data);
Copy link
Collaborator

@HennerM HennerM Jul 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we still default to modelType though? So that it doesn't fail in the rare case there is no type field?

Copy link
Author

@mpugach mpugach Jul 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, looks like it is a good idea

maybe it needs some documentation also, do not remember

anyway we ended up ejecting the library from our projects due to the lack of responsiveness to our PRs

so I do not feel like continuing with this one. I gonna close the PRs

thank you for your comment

this.addToStore(model);

if (body.included) {
Expand Down