Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Conversation

@ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jul 17, 2019

  • when trying to clear a filter that was empty, there is no reason to trigger a filter change
  • to replicate the issue, you could go to the OData or GraphQL example and hover over a column with an empty filter, then choose "Clear Filter" from the header menu. The spinner should stop

- when trying to clear a filter that was empty, there is no reason to trigger a filter change
@codecov-io
Copy link

codecov-io commented Jul 17, 2019

Codecov Report

Merging #241 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   75.31%   75.33%   +0.02%     
==========================================
  Files         145      145              
  Lines        6962     6966       +4     
  Branches     2209     2211       +2     
==========================================
+ Hits         5243     5247       +4     
  Misses       1719     1719
Impacted Files Coverage Δ
...dules/angular-slickgrid/services/filter.service.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1924368...1485f2b. Read the comment docs.

@ghiscoding ghiscoding merged commit e10f49f into master Jul 19, 2019
@ghiscoding ghiscoding deleted the bugfix/backend-clear-filter branch July 19, 2019 23:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants