Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Conversation

@ghiscoding
Copy link
Owner

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 23, 2019

Codecov Report

Merging #273 into master will increase coverage by 1%.
The diff coverage is 85.72%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
+ Coverage   78.34%   79.33%   +1%     
=======================================
  Files         134      134           
  Lines        7296     7323   +27     
  Branches     2505     2520   +15     
=======================================
+ Hits         5715     5809   +94     
+ Misses       1581     1514   -67
Impacted Files Coverage Δ
.../modules/angular-slickgrid/editors/selectEditor.ts 14.29% <0%> (-0.05%) ⬇️
...es/angular-slickgrid/filters/autoCompleteFilter.ts 17.65% <0%> (-0.23%) ⬇️
.../modules/angular-slickgrid/filters/selectFilter.ts 99.55% <100%> (+33.37%) ⬆️
...pp/modules/angular-slickgrid/services/utilities.ts 100% <100%> (ø) ⬆️
...s/angular-slickgrid/services/collection.service.ts 100% <100%> (ø) ⬆️
.../angular-slickgrid/filters/multipleSelectFilter.ts 100% <0%> (+40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d357148...8569970. Read the comment docs.

Ghislain Beaulac added 2 commits August 23, 2019 11:59
- also deprecated `collectionInObjectProperty` and rename it to `collectionInsideObjectProperty`
@ghiscoding ghiscoding changed the title feat(tests): add SelectFilter unit tests feat(tests): add unit tests for SingleSelect & MultipleSelect Filters Aug 23, 2019
@ghiscoding ghiscoding merged commit 8c1f835 into master Aug 23, 2019
@ghiscoding ghiscoding deleted the feat/multiple-select-filter-tests branch September 1, 2019 14:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants