This repository was archived by the owner on Jun 1, 2025. It is now read-only.
fix(pagination): when item is added it should trigger pagination changed #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
==========================================
+ Coverage 97.29% 97.33% +0.05%
==========================================
Files 135 135
Lines 7612 7634 +22
Branches 2474 2483 +9
==========================================
+ Hits 7405 7430 +25
+ Misses 207 204 -3
Continue to review full report at Codecov.
|
- manually adding items (via the grid service addItem()) shouldn't reset pagination to page 1 - completely change how we pass the options to the child pagination component - no longer relying on the entire grid option to be passed to the pagination (which was error pron) - now passes only the essential options required by the pagination
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.