Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Conversation

@ghiscoding
Copy link
Owner

  • a new flag "addListSeparator" was added to the GraphQL Backend Service, this flag when set will ask the GraphQL on the backend side to return the current user list separator (in English it's a comma but in French it's a semicolon). For example, with .Net Core, we can get this list separator by the CultureInfo.TextInfo.ListSeparator

@codecov-io
Copy link

codecov-io commented Oct 8, 2019

Codecov Report

Merging #306 into master will decrease coverage by 0.05%.
The diff coverage is 79.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
- Coverage   97.33%   97.28%   -0.04%     
==========================================
  Files         135      135              
  Lines        7634     7641       +7     
  Branches     2483     2486       +3     
==========================================
+ Hits         7430     7433       +3     
- Misses        204      208       +4
Impacted Files Coverage Δ
...lickgrid/components/angular-slickgrid.component.ts 61.21% <0%> (-0.67%) ⬇️
...dules/angular-slickgrid/services/export.service.ts 100% <100%> (ø) ⬆️
...ules/angular-slickgrid/services/graphql.service.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7550262...ba6082c. Read the comment docs.

@ghiscoding ghiscoding merged commit fb6a6f3 into master Oct 8, 2019
@ghiscoding ghiscoding deleted the feat/export-csv-list-separator-detection branch October 16, 2019 23:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants