This repository was archived by the owner on Jun 1, 2025. It is now read-only.
fix(pagination): never display page 0, minimum should be page 1 #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- if we filter the data and an empty dataset is returned, we should display "Page 1 of 1", not "Page 0 of 0". - Also instead of "0-0 of 0 items", we should hide the "0-0" and only display "0 items" - update Cypress E2E test
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
==========================================
+ Coverage 99.71% 99.71% +0.01%
==========================================
Files 138 138
Lines 8038 8041 +3
Branches 2731 2733 +2
==========================================
+ Hits 8014 8017 +3
Misses 24 24
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches roughly what UI-Grid does (in their case, they actually even hide the total count).
this fixes some small issues that I have seen, sometime the page 0 of 0 was sticking even though we - removed the filter, so it's better to use Page 1 of 1 as a minimum
BEFORE
AFTER
