Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Conversation

@ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Mar 17, 2020

  • when using both together, 1 was cancelling the other. To fix this, I rewrote the code use text split by the decimal and then recombining them as a new text with necessary thousand & decimal separators

  • fix code

  • add unit tests to cover both properties used at the same time

with updated code, the result is now as shown below

  1. first column has thousandSeparator: '.' and decimalSeparator: ','
  2. second column has thousandSeparator: ',' and decimalSeparator: '.'

image

- when using both together, 1 was cancelling the other. To fix this, I rewrote the code use text split by the decimal and then recombining them as a new text with necessary thousand & decimal separators
@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #415 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #415    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files         141    141            
  Lines        8857   8863     +6     
  Branches     3055   2931   -124     
======================================
+ Hits         8857   8863     +6
Impacted Files Coverage Δ
...pp/modules/angular-slickgrid/services/utilities.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72870f4...af146fb. Read the comment docs.

@ghiscoding ghiscoding merged commit 4aa9a91 into master Mar 18, 2020
@ghiscoding ghiscoding deleted the bugfix/decimal_thousand_separators branch March 18, 2020 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants