Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Conversation

@ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Dec 2, 2020

  • when calling "hide column" we need to readjust the freezingColumn by (-1) when on left container
  • when showing/hiding a column from ColumnPicker/GridMenu, we need to check if we need to also readjust when column is on the left container

TODOs

  • add all Jest unit tests
  • add Cypress E2E test
  • requires core SlickGrid PR #561 to be merged & released

nAiAGpimeG

- when calling "hide column" we need to readjust the freezingColumn by (-1) when on left container
- when showing/hiding a column from ColumnPicker/GridMenu, we need to check if we need to also readjust when column is on the left container
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #642 (7907cb8) into master (13809b4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #642    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          154       154            
  Lines        10301     10333    +32     
  Branches      3614      3478   -136     
==========================================
+ Hits         10301     10333    +32     
Impacted Files Coverage Δ
...lickgrid/components/angular-slickgrid.component.ts 100.00% <100.00%> (ø)
...ular-slickgrid/extensions/columnPickerExtension.ts 100.00% <100.00%> (ø)
...s/angular-slickgrid/extensions/extensionUtility.ts 100.00% <100.00%> (ø)
.../angular-slickgrid/extensions/gridMenuExtension.ts 100.00% <100.00%> (ø)
...ngular-slickgrid/extensions/headerMenuExtension.ts 100.00% <100.00%> (ø)
...dules/angular-slickgrid/services/shared.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13809b4...7907cb8. Read the comment docs.

@ghiscoding ghiscoding merged commit 07d190b into master Dec 2, 2020
@ghiscoding ghiscoding deleted the bugfix/hiding-showing-frozen-column-index branch December 2, 2020 21:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants