Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Conversation

@ghiscoding
Copy link
Owner

  • when using 2 dots notation (2..5), we should use defaultFilterRangeOperator when none is provided and/or isn't a range operator

- when using 2 dots notation (`2..5`), we should use `defaultFilterRangeOperator` when none is provided and/or isn't a range operator
@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #705 (83a05de) into master (7219249) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #705   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          159       159           
  Lines        10611     10617    +6     
  Branches      3754      3756    +2     
=========================================
+ Hits         10611     10617    +6     
Impacted Files Coverage Δ
...dules/angular-slickgrid/services/filter.service.ts 100.00% <ø> (ø)
...slickgrid/filter-conditions/dateFilterCondition.ts 100.00% <100.00%> (ø)
...ickgrid/filter-conditions/numberFilterCondition.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7219249...83a05de. Read the comment docs.

@ghiscoding ghiscoding merged commit a176037 into master Feb 27, 2021
@ghiscoding ghiscoding deleted the bugfix/range-filter-default-operator branch February 27, 2021 02:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants