This repository was archived by the owner on Jun 1, 2025. It is now read-only.
fix(footer): use getFilteredItemCount to show correct item count
#832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct item count - fixes Slickgrid-Universal issue [#469](ghiscoding/slickgrid-universal#469) - we should always use DataView `getFilteredItemCount()` since that is really the item count that we want to show in the footer `getFilteredItemCount` to show correct count, fix #469 - fixes #469 - we should always use DataView `getFilteredItemCount()` since that is really the item count that we want to show in the footer
ghiscoding
changed the title
getFilteredItemCount to show corre…getFilteredItemCount to show correct item count
ghiscoding
changed the title
getFilteredItemCount to show correct item countgetFilteredItemCount to show correct item count
Codecov Report
@@ Coverage Diff @@
## master #832 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 1075 1075
Branches 330 335 +5
=========================================
Hits 1075 1075
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getFilteredItemCount()since that is really the item count that we want to show in the footergetFilteredItemCountto show correct count, fix fix(locale): use correct locale text operator tooltip, closes #468 #469getFilteredItemCount()since that is really the item count that we want to show in the footer