fix: close() fn and options.onClose() should only be called w/open drop
#442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when instantiating ms-select with option
{ isOpen: true }, we delay the opening of the drop by a CPU cycle. However the issue is that theinitContainer()has aclickevent listener on thedocument.bodyand when{ isOpen: true }is provided, it triggers the click event (not really sure why but it doesn't really matter) and the bug is that we should allow theclose()andoptions.onClose()to be called only if the drop is really open (and it's not opened until the CPU cycle delay, so we need another internal_isOpenvariable to reference and with that in place the close isn't being called anymore when we first open originally open the drop)This fixes an issue identified in Slickgrid-Universal were it was calling the
options.onClose()when creating and opening the drop... so with the fix in place, it no longer calls the onClose() on the original drop opening.