Skip to content

fix: close() fn and options.onClose() should only be called w/open drop #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
Merged

fix: close() fn and options.onClose() should only be called w/open drop #442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/multiple-select-vanilla/src/MultipleSelectInstance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ const OPTIONS_HIGHLIGHT_LIST_SELECTOR = '.ms-select-all.highlighted, ul li[data-

export class MultipleSelectInstance {
protected _bindEventService: BindingEventService;
protected _isOpen = false;
protected isAllSelected = false;
protected isPartiallyAllSelected = false;
protected fromHtml = false;
Expand Down Expand Up @@ -275,11 +276,9 @@ export class MultipleSelectInstance {
return;
}

if (
(this.getEventTarget(e) === this.dropElm ||
(findParent(this.getEventTarget(e), '.ms-drop') !== this.dropElm && this.getEventTarget(e) !== this.elm)) &&
this.options.isOpen
) {
const eventTarget = this.getEventTarget(e);
const fpDropElm = findParent(this.getEventTarget(e), '.ms-drop');
if (this._isOpen && (eventTarget === this.dropElm || (fpDropElm !== this.dropElm && eventTarget !== this.elm))) {
this.close('body.click');
}
}) as EventListener,
Expand Down Expand Up @@ -1306,6 +1305,7 @@ export class MultipleSelectInstance {
this.highlightCurrentOption();
}

this._isOpen = true;
this.options.onOpen();
}

Expand Down Expand Up @@ -1460,6 +1460,7 @@ export class MultipleSelectInstance {
}

close(reason?: CloseReason) {
this._isOpen = false;
this.options.isOpen = false;
this.parentElm.classList.remove('ms-parent-open');
this.choiceElm?.querySelector('div.ms-icon-caret')?.classList.remove('open');
Expand Down
Loading