feat(editors): add min/max length options to text editors - #30
Merged
Conversation
- add a text length counter (currentTextLength/maxLength) to the LongText Editor - the new `minLenght`, `maxLength` options can be used by the following Editors (autoComplete, longText, text) - also flip the position of the Cancel/Save buttons, Cancel should be on the left and Save on the right
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 99.60% 99.60% +0.01%
==========================================
Files 185 185
Lines 10017 10062 +45
Branches 3297 3415 +118
==========================================
+ Hits 9976 10021 +45
Misses 41 41
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minLenght,maxLengthoptions can be used by the following Editors (autoComplete, longText, text)